t9md / atom-vim-mode-plus

vim-mode improved
https://atom.io/packages/vim-mode-plus
MIT License
1.4k stars 111 forks source link

vim mode cursor disappears in Atom 1.24-beta0 #998

Closed pingshunhuangalex closed 6 years ago

pingshunhuangalex commented 6 years ago

Check list

You have to check all before open issue.

hultberg commented 6 years ago

When I press Ctrl+S (save file - vim goes into Normal mode) the cursor appears, but its gone when I go in Insert mode again.

dsandstrom commented 6 years ago

It's the opposite for me. The I-bar cursor is visible in insert mode. The block cursor is not visible in normal and visual modes. The cursor works fine in Atom v1.22 and the last beta (v1.23?).

thancock20 commented 6 years ago

I guess I should have looked here before I started messing with my styles.less file. But at least I do know that commenting out the entire file still causes this problem.

To be more specific, the I-bar is visible in insert mode. The block cursor is not visible until I save the file, then it appears. But it disappears again if I switch to another mode and then back to normal.

pertrai1 commented 6 years ago

Yeah, it is weird. As long as I save every time then it will come back. Do some work, save, do some work, save. etc...

ykpythemind commented 6 years ago

I had same problem.

Probably It is related to https://github.com/atom/atom/pull/16294

I found temporary solution.

Open file ~/.atom/packages/vim-mode-plus/lib/vim-state.js
https://github.com/t9md/atom-vim-mode-plus/blob/0cf95301bd0b3b4ddae8ed74948771e1e7a5f069/lib/vim-state.js#L491-L499 and Insert code this.editor.setReadOnly(false) after line 497 and Reload Window (^⌥⌘L)

sorry if it is not correct

pertrai1 commented 6 years ago

@ykpythemind - that did the trick for now. Thank you

hultberg commented 6 years ago

@ykpythemind Works for me. Just wanted to say (in case others attempt the workaround), the line number 497 did not match in my local vim-state.js file.

ykpythemind commented 6 years ago

@hultberg I think you have to update vim-mode-plus to latest version (v1.24.0)

t9md commented 6 years ago

Hi, thanks for investigating issue, I'll look into this. First, I'll update my Atom.app from now.

t9md commented 6 years ago

@ykpythemind picked your fix without investigating issue throughly. Released v1.24.1 now. Thanks.

Be noted lots of features are still broken in beta as it were in every beta release timing. Using beta channel means you see such breaking on next beta timing too. So I basically don't recommend to use bata in work environment(being stopped what you want by sudden breaking is really frustrating I believe).

t9md commented 6 years ago

I cannot find reasonable way to fix this issue. Quick fix is not really fixed issue. This is basically atom-core upstream issue. I cannot fix this, and cannot do anything unless upstream just revert that bad PR.

pingshunhuangalex commented 6 years ago

Thanks @t9md

At least for me, I'm aware that Beta has a higher chance of breaking things. I think it's good we discover the issue now and narrow things down to an atom-core upstream issue. Otherwise, it'll sneak into the prod anyway, which will spread even more frustration.

Thanks for the help, and feel free to close this issue whenever you see fit. Thanks.

t9md commented 6 years ago

keep this open. Since it's not fixed, just pretending to be fixed by just showing cursor. In current fix, buffer is actually editable, type q or enable IME and input some key.

What I'm doing is asking them to revert this PR atom/atom#16294 in strong manner.

t9md commented 6 years ago

Commit made on upstream-Atom-core which have bad effects to vmp was reverted now. Thanks for github team for hearing vmp author/vmp users.

After Atom-v1.24.0-beta1 was released maybe tonight, and you updated vmp to just released vmp-v1.24.3, you should be able to use Atom-beta without problem :tada:

dsandstrom commented 6 years ago

Thanks @t9md it's fixed in Atom v1.24-beta1