tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
235 stars 19 forks source link

Refactor Fit objects #133

Closed tBuLi closed 6 years ago

tBuLi commented 7 years ago

This PR represents a mayor overhaul of the internal structure of Fit objects in symfit.

Fit is now responsible for feeding an Objective function to a Minimizer, it is no longer the combination of these two.

This means two new types of object have been introduced; Minimizers and Objectives. This change should make it easier for people to introduce a new Minimizer while being completely agnostic about which objective function to use.

To do (not a complete list, work in progress):

pckroon commented 7 years ago

We need to address one more thing in this fell swoop, and that is to decide how the arguments are called that fit.execute (and thereby Minimizer.execute) is to accept, and what it should return. In the process we should standardise some names.

tBuLi commented 6 years ago

Note: The error that now remains in this branch is one that will be solved my merging with @pckroon's finite differences branch, because then stdev's for ODEModels can be calculated.

pckroon commented 6 years ago

Looking good! Note that you should probably fix #56 before tagging and releasing.