Update Python versions for Travis. Remove Sphinx version pinning

tBuLi / symfit

Symbolic Fitting; fitting as it should be.

http://symfit.readthedocs.org

MIT License

233 stars 17 forks source link

Update Python versions for Travis. Remove Sphinx version pinning #225

Closed pckroon closed 5 years ago

pckroon commented 5 years ago

Py3.4 is no longer supported and removed from Travis. In addition, Py3.7 is added.

Also, it seems that pinning sphinx to 1.5.5 is no longer necessary. Locally I can run sphinx 2.0.0 in nitpicky mode without issues.

pckroon commented 5 years ago

Also, for your consideration: I can also set up build-stages, for example: https://travis-ci.org/marrink-lab/vermouth-martinize

tBuLi commented 5 years ago

I've had a quick look and the stages do make everything look a lot more presentable so if you would be willing to do that, you have my full support!

Also, how the hell does this decrease coverage? The wonders of coverage.

pckroon commented 5 years ago

As to the decrease in coverage I have a suspicion: In construct like this:

for ...:
   if ...:
       continue/break

or for: else: continue python optimizes away the execution of the continue/break line. So coverage never sees them as being executed. My guess is that this optimization became more powerful in 3.7.