search

tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
233 stars 17 forks source link

Fix 215 #229

Closed tBuLi closed 5 years ago

tBuLi commented 5 years ago

In response to #215, I added a simple warning to prevent this confusion in the future.

tBuLi commented 5 years ago

That's a much bigger job than this PR. I wouldn't call unittest2 a third party app, it's just a backport of newer unittest facilities that don't exist in py27 but make supporting it much easier. I don't think it is worth it to deal with py27 warning handling for testing for the couple of py27 users left (hopefully).

pckroon commented 5 years ago

I don't intend this PR to redo all the tests. Instead, just use e.g. with pytest.warns rather than unittest2: https://docs.pytest.org/en/latest/warnings.html

tBuLi commented 5 years ago

Ah, that changes things. That's a good idea, I'll change it.