search

tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
233 stars 17 forks source link

master tests fail on HadamardProduct #297

Closed Jhsmit closed 4 years ago

Jhsmit commented 4 years ago

The HadamardProduct in test_constrained raises an error:

NameError: name 'HadamardPower' is not defined

It seems like somewhere Power and Product got mixed up?

Might be related to https://github.com/sympy/sympy/issues/17138

tBuLi commented 4 years ago

It was due to HadamardPower being added in sympy 1.5, which was not printed yet. I solved it now in #300.

As a tip to you, I think you should rebase all your PR's on the current master to get better testing, or alternatively merge master into it.