search

tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
233 stars 17 forks source link

pytest failures #307

Closed stephanlachnit closed 3 years ago

stephanlachnit commented 4 years ago

pytests fails in two tests for me, here are the problems I found:

https://github.com/tBuLi/symfit/blob/f8748393696709d2d8a0d51f6d549749eb6e1412/tests/test_constrained.py#L848 This line causes the test to fails when running pytest, however I don't get any warning if I call the function from a Python console. Maybe related to #262, but as I said I wasn't able to get any warning or error from that function.

https://github.com/tBuLi/symfit/blob/ed20d296a818f6e8ce89efae4e9f3dce635ff4db/tests/test_ode.py#L250 Always fails for me. I get c0 = 2.317258e-07 +- 9.973437e-11, so this might just be a too tight assertion tolerance.

brocksam commented 3 years ago

This issue would be closed by merging PR #317.

Jhsmit commented 3 years ago

@pckroon I think this can be closed