search

tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
233 stars 17 forks source link

Change license to MIT #321

Closed pckroon closed 3 years ago

pckroon commented 3 years ago

This PR changes the license to MIT, as discussed in #309, and adds SPDX license headers to all py files (excluding the examples). I didn't add the license header to core/leastsqbound.py, I seem to remember we borrowed that code from elsewhere. @tBuLi do you remember?

Closes #309

tBuLi commented 3 years ago

Correct, leastsqbounds is a direct copy paste of a repo with the same name. (There should also be an open issue to remove this since this functionality has since been included in scipy, but that’s another PR)

tBuLi commented 3 years ago

Might be a noob question, but what are these SPDX headers for?

pckroon commented 3 years ago

Correct, leastsqbounds is a direct copy paste of a repo with the same name. (There should also be an open issue to remove this since this functionality has since been included in scipy, but that’s another PR)

I'll remove that file in this PR then, since it does have implications for the license.

Might be a noob question, but what are these SPDX headers for?

Every file needs a header stating under what license it can be distributed. As I understand the SPDX format is just a short, standardized way of doing that. @stephanlachnit?

stephanlachnit commented 3 years ago

Might be a noob question, but what are these SPDX headers for?

Every file needs a header stating under what license it can be distributed. As I understand the SPDX format is just a short, standardized way of doing that. @stephanlachnit?

Yes exactly. It's a standard from the Linux Foundation (slightly changed from the Free Software Foundation Europe to standardize the copyright owner) to easily parse files for their copyright.

With this standard it's easy to import files from other repos and still respect their copyright information, also you can quickly create copyright reports, which might be usefull for example for distributors like Debian.

stephanlachnit commented 3 years ago

@tBuLi is there any chance we can get this merged with a new release before February? Else it won't make it for the Debain 11 freeze starting on February 12th.

pckroon commented 3 years ago

@stephanlachnit Sorry for the long wait and the missed deadline! Maybe we can try again with Debian 12?

stephanlachnit commented 3 years ago

Jup, no problem. I will package it anyway a soon a there is a ne release.

pckroon commented 3 years ago

Awesome thanks! Will you get notified automatically once there's a new release, or should I @ you somewhere once we mint a new release?

stephanlachnit commented 3 years ago

I'm subscribed to the GitHub releases, so as long as they will still be done I will get notified.

stephanlachnit commented 3 years ago

Are there any plans to release a new version? Debian 11 has released now and new software can be added, and I would love to add symfit.