tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
236 stars 19 forks source link

Test failures #342

Closed pckroon closed 2 years ago

pckroon commented 3 years ago

A number of tests are failing. This PR fixes them. Most failures come from pickle complaining about the slots of the Argument class. sympy.Symbol used to provide the necessary __setstate__ method, but not anymore. In addition, its __getstate__ method started returning None rather than an empty dict.

Besides that there's a test that fails due to numerical reasons. This is addressed by slightly changing the values used. It seems much more robust now though, removing the random seed didn't affect the result.