search

tBuLi / symfit

Symbolic Fitting; fitting as it should be.
http://symfit.readthedocs.org
MIT License
232 stars 17 forks source link

No compatible with numpy 1.24.1 #363

Closed stephanlachnit closed 1 year ago

stephanlachnit commented 1 year ago

Reported originally here.

The expired deprecation are listed here.

pckroon commented 1 year ago

Thanks for reporting this. As far as I can see this has already been fixed in #342 via 1b683233d1e0c2ced5e96c9630fd3aeb22ca982c

stephanlachnit commented 1 year ago

Thanks for reporting this. As far as I can see this has already been fixed in #342 via 1b68323

Ah good to know, thanks! Can you tag a new release with this?

pckroon commented 1 year ago

@tBuLi ?

tBuLi commented 1 year ago

Thanks for your help. I will tag a new release ASAP, although I would also like to merge #365 first, because that also represents a significant but straightforward clean-up of the code base. So I expect a new release will be made by the end of the week.

tBuLi commented 1 year ago

I just made a new release. But looking back on this discussion something seems off to me: #342 was already merged and present in earlier releases. So it seems to me that this issue might still exist?

pckroon commented 1 year ago

When I looked I couldn't find the changes made in that PR in the latest release. I also couldn't reproduce the original issue on the main branch.

@stephanlachnit Can you confirm this is fixed in yesterday's release?

stephanlachnit commented 1 year ago

@stephanlachnit Can you confirm this is fixed in yesterday's release?

Seems to be fixed, closing.

pckroon commented 1 year ago

Great! Thanks again for reporting this, and thanks for reporting back