search

tGecko / ChampSelectSpy

GNU General Public License v3.0
36 stars 17 forks source link

Missing or incorrect names #2

Closed cubedsphered closed 1 year ago

cubedsphered commented 1 year ago

I've noticed many of the lobbies I'm in, the tool detects 4 names (1 missing) or displays the incorrect name. I'm thinking this might be because of the code picking up Riot ID instead of Summoner ID/Name. Works as intended for majority of players, this is the exclusion. well done

cubedsphered commented 1 year ago

I should mention, in most cases, the player will have Riot ID same as Summoner Name, however, many Valorant players will have changed their Riot ID to something different than their League name.

tGecko commented 1 year ago

Thank you very much, I think I identified the issue (I'm using the field "game_name" instead of just "name") and will fix this ASAP (next 2 hours)

EDIT: I kinda saw this coming as I saw the 2 fields name and game_name and in my tests they always were the same. Seems I got unlucky when testing.

tGecko commented 1 year ago

Kindly test Release 1.3. If you could report back it'd help me very much.

kartoffelsaretasty commented 1 year ago

It works a lot better now, only very rarely it doesn't return a valid summoner (but in the 2 occasions that happened, the summoner was equal to what the program returned, just not registered at op.gg after a namechange)

So I think you fixed it, thanks!

tGecko commented 1 year ago

Thank you very much for your feedback.

cubedsphered commented 1 year ago

I've tested it using multiple lobbies, it works 100% of the time now -- sorry for the wait, I wanted to make sure I used it in more than 1 lobby before I made a comment again

tGecko commented 1 year ago

Thanks a lot for reporting the issue and the feedback @cubedsphered !

IthielMS commented 1 year ago

I've getting a trouble with the app, never worked to me in too many lobbies, i dont have idea of what can be, but dont show up names and dont appear the Summoner and Gamestate, just dont work. Can u help me?

cubedsphered commented 1 year ago

This is a separate issue; please file under new issue.