search

tGecko / ChampSelectSpy

GNU General Public License v3.0
36 stars 17 forks source link

FeatureRequest - Porofessor.gg search #4

Closed cubedsphered closed 1 year ago

cubedsphered commented 1 year ago

I think U.GG is OK (fetches latest data semi-regularly), OP.GG is terrible (fetches last manual-update data, useless if they dont refresh their profiles regularly) but ... Porofessor.gg always fetches the most recent data, without fail, and with more stats displayed than the others. Here's standard URL, and specifiers explained (I tested them personally): https://porofessor.gg/pregame/euw/placeholder/soloqueue/season

  1. euw may be changed to any region accordingly.
  2. placeholder is replaced by normal comma list of summoners (comma+space, e.g.: "A, B, C, D, E").
  3. /soloqueue specifies games counted, can be replaced with /ranked-only for both solo and flex, or removed entirely for all games (normal + ranked)
  4. /season is always at the end, can be removed to fetch only last 30 days of data (GREAT, since more recent data is more relevant)

I personally use https://porofessor.gg/pregame/euw/placeholder/soloqueue. I'd suggest this specific one, with maybe the /season added if you desire.

P.S. These sites may remove pre-game pages entirely due to less demand by players; IF this happens, coding to pull up the leagueofgraphs.com page for each listed profile will be good. Same advantage as with Porofessor, updates more regularly than u.gg or op.gg. P.P.S. If I knew coding, I'd do these changes myself, you've done plenty.

Thanks for reading... Happy New Year! 🎉

philipp-heller commented 1 year ago

How is the status on this one? else I would try to implement it myself and send a merge after

tGecko commented 1 year ago

Feel free to submit a PR, i had this planned but life happened.

matijuguera commented 1 year ago

we could add it with chat gpt. I will take a look on it as soon as I have free time

tGecko commented 1 year ago

Implemented by @philipp-heller in PR #6