tOverney
commented
8 years ago Thank you for the feedback!
- I've proof-read the README, https://github.com/tOverney/ADA-Project/commit/e7a3c98ce9877ac163c30ab5246387012efd8269 fixes it (at least to the best of my abilities)!
- We planned on using Wikidata, I should have been more precise when saying Wikipedia data...
- Github hosting is a good idea! If we have extra time we'd still want to make a live version of the SBB network occupancy which would require a bit more than just a js page, but it's far from being our priority.
LGTM! Just a few remarks:
proof-read the README (especially with a spell checker :)
consider querying Wikidata instead of scraping Wikipedia. You should be able to get the information you want directly in JSON.
architect the whole project as a static "app" -- you should be able to host the website on GitHub pages, using only HTML/CSS/JS. If you want to make the project "updatable", just include a python script that fetches the new data, re-run the processing, and updates the JSON files loaded by the static app.