tSQLt-org / tSQLt

The official tSQLt repository. (Download at: http://tSQLt.org/downloads )
http://tSQLt.org
413 stars 102 forks source link

Typo prevents from publishing to Case sensitive server #155

Closed andreassundstrom closed 2 years ago

andreassundstrom commented 2 years ago

In the procedure tSQLt.Private_NoTransactionHandleTable there is a typo preventing us from publishing tSQLt to case sensitive server. Should be @cmd. https://github.com/tSQLt-org/tSQLt/blob/c63e2d268a136154fad3648bc41cf4fd32bd2106/Source/tSQLt.Private_NoTransactionHandleTable.ssp.sql#L25 Variable declaration:

  DECLARE @cmd NVARCHAR(MAX);

I can submit PR for fix if you want, but I'm not very faimiliar with the project.

mbt1 commented 2 years ago

Marking this as a bug. We'll work on getting a case-sensitive server into the build pipeline. (To clarify, all build databases are already case sensitive. That SQL Server shows different behavior when the server collation is case sensitive I was not aware of.)

lizbaron commented 2 years ago

Fixed and tested. Merged to main. Will publish shortly.

andreassundstrom commented 2 years ago

@lizbaron Will this be available from the tSQLt website, or do you scheduele releases?

mbt1 commented 2 years ago

The release (V1.0.8083.3529) is now available on tSQLt.org. Please go to the download page to get it.

andreassundstrom commented 2 years ago

Wow amazing, awesome work. This will really help our company implementing sql server unit testing in our Swedish health care environment. Thank you so much for quick response!