ta-oliver / infertrade

Open source trading and investment strategy library designed for accessibility and compatibility
Apache License 2.0
34 stars 20 forks source link

Refactor community allocation rules into individual files #145

Closed ta-oliver closed 3 years ago

ta-oliver commented 3 years ago

Current Situation

Currently we are adding all our community allocation rules to one large file.

Currently when we add a new rule we need to edit the file and (dictionary), which does not align with "software entities (classes, modules, functions, etc.) should be open for extension, but closed for modification".

Suggested refactorings

We could split this up to either 1 file per rule or small numbers of related rules grouped in files. Potentially we could also consider sorting the rules into directories.

This issue is to discuss the potential architectural options given the following considerations: