search

taarifa / Taarifa_Web

THIS CODE BASE IS DEPRECATED AND ONLY HERE FOR ARCHIVAL PURPOSES!
http://www.taarifa.org
Other
18 stars 6 forks source link

Remove the hard requirement for a Google Maps API Key #5

Closed taarifa closed 12 years ago

taarifa commented 12 years ago

We are an open project, so it makes sense for us to develop and support other open-source projects. Currently Taarifa forces users, on installation, to input a google maps API key, regardless if the user is wanting to use google maps or not.

This presumably is necessary for google maps, but progress is inhibited for other map providers. So make it so the API is only necesary if the user wishes to use google maps.

John07 commented 12 years ago

From my limited understanding of the code in install.php it checks whether $map_api_key is entered (line 200) regardless of the selected $map_provider. So I propose this to be changed to only require an API key if the user selects Google as a map_provider. If the user later changes his mind, he can add an API key in the map settings. Any objections?

Here's a screenshot of this step in the installation process: http://cl.ly/Dmil

kynan commented 12 years ago

Very sensible suggestion, no objections.