In the original version of jssocial, I found that the title variable was missing from shareurls that were supposed to have it. I checked the code, but couldn't find the title variable defined anywhere, so I've added it.
This is my first pull request ever (I'm nervous!) I have read the contributing notes.
I've not done the grunt tests, but I've run github/jssocials/test/jssocials.html
Everything passed except for share rendering: set custom handlers with 'on', but I think it is to be expected in this case. Here are the results of that test.
In the original version of jssocial, I found that the title variable was missing from shareurls that were supposed to have it. I checked the code, but couldn't find the title variable defined anywhere, so I've added it.
This is my first pull request ever (I'm nervous!) I have read the contributing notes. I've not done the grunt tests, but I've run github/jssocials/test/jssocials.html Everything passed except for share rendering: set custom handlers with 'on', but I think it is to be expected in this case. Here are the results of that test.
I've tested a different branch (that contained the above changes) on my server and the title variable was correctly added to the url.
If I've gone about this pull request incorrectly, made any mistakes or you have any feedback, I'd love to hear it. Thanks!