Resolve #113 - Githubissues

tabatkins / railroad-diagrams

:steam_locomotive: A small JS+SVG library for drawing railroad syntax diagrams, like on JSON.org. Now with a Python port!

MIT License

1.66k stars 153 forks source link

Closed voidvoxel closed 4 months ago

voidvoxel commented 7 months ago

Resolve #113

voidvoxel commented 7 months ago

generator.html still functions as intended. I tested this in the Brave browser.
generator.html no longer reports an error in Snyk. I tested this by changing one of my personal packages (@voidvoxel/parse-function) to specifically refer to the fork with the changes, and Snyk no longer reported that error on the package.

yaadkarim commented 5 months ago

@tabatkins can you merge this please?

tabatkins commented 4 months ago

No, this is an incorrect fix (it double-encodes values), and the original vulnerability is a false positive.