tabatkins / railroad-diagrams

:steam_locomotive: A small JS+SVG library for drawing railroad syntax diagrams, like on JSON.org. Now with a Python port!
MIT License
1.66k stars 153 forks source link

[2.0.3] Available from PIP for Ubuntu 18.04 + Python 3.6 #96

Closed hswong3i closed 2 years ago

hswong3i commented 2 years ago

From https://github.com/tabatkins/railroad-diagrams/commit/7fc0602821214267eaa8c6c3b0826589a7ccc950 the minimal Python requirement >= 3.7, but https://pypi.org/project/railroad-diagrams/2.0.3/ is still availble from PIP for Ubuntu 18.04 + Python 3.6:

root@748b3d29b97a:~# lsb_release -a
LSB Version:    core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.6 LTS
Release:    18.04
Codename:   bionic

root@748b3d29b97a:~# python3 --version
Python 3.6.9

root@748b3d29b97a:~# pip list --outdated | grep railroad-diagrams
railroad-diagrams 1.1.1   2.0.3  wheel

By adding python_requires=">= 3.7" to setup.py we could prevent this behavior precisely.

Signed-off-by: Wong Hoi Sing Edison hswong3i@pantarei-design.com

hswong3i commented 2 years ago

Please also kindly yank 2.0.0, 2.0.1, 2.0.2 and 2.0.3 from https://pypi.org/project/railroad-diagrams/, if possible ;-)

hswong3i commented 2 years ago

For now I give a quick dirty workaround with https://github.com/alvistack/tabatkins-railroad-diagrams/commit/b3ded9548fa84b685f2957809708ea11ac37b798#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7, also manually disable https://build.opensuse.org/repositories/home:alvistack/tabatkins-railroad-diagrams-2.0.3 OBS build for any Python < 3.7 OS.

tabatkins commented 2 years ago

Right, I always forget you've got to update multiple things to let the nice computer know what versions you support. Sigh.

Okay, 2.0.4 released with a python_requires, and yanked the other 2.0.* versions.

hswong3i commented 2 years ago

@tabatkins seems the changes didn't go to our GIT commit yet? But just changed locally and pushed to Pypi directly?

tabatkins commented 2 years ago

Sigh, yeah, pushed to GH now. ^_^

hswong3i commented 2 years ago

@tabatkins yes get the commit from GH now ;-)

BTW, wish you a kindly consideration for #91, which could also simplify our life as downstream deb/rpm packager, and so we could also providing you feedback ASAP if case happened as this PR ;-)