search

tabdulradi / puretracing

opentracing for pure applications
Apache License 2.0
17 stars 6 forks source link

Initial setup for http4s #1

Open gvolpe opened 5 years ago

gvolpe commented 5 years ago

There's still more work to do but having an initial proposal to start a discussion seems like a good step forward :smiley:

tabdulradi commented 5 years ago

I just noticed I don't have a license yet. opentracing-java itself is using Apache 2.0, I am inclined to use the same. What do you think?

tabdulradi commented 5 years ago

I'll take a stab at implementing inject/extract in a separate PR.

tabdulradi commented 5 years ago

This PR should unblock you https://github.com/tabdulradi/puretracing/pull/2 The headers are hard-coded to be Map[String, String] for now, which is fine for the first cut, but later we have to support ByteBuffer as well.

gvolpe commented 5 years ago

I'm okay with Apache 2.0 :+1: . Going on holidays until the 2nd week of January but I should be able to make some progress once I'm back with the given feedback. Happy holidays :santa:

tabdulradi commented 5 years ago

I just pushed a method that should make root span creation easier https://github.com/tabdulradi/puretracing/pull/5/files#diff-ebd9fafd979331dced1fa2dc2b36a6c0R15

gvolpe commented 5 years ago

@tabdulradi I honestly don't have any time to continue working on this at the moment. I believe you want to quickly move forward so it's okay if you want to continue working on this PR or you can just close it and work on a different PR.

tabdulradi commented 5 years ago

@gvolpe Thanks for your work so far, I'll finalise it. Thanks again for contribution.