search

tabeyti / jenkins-jack

Jack into your Jenkins to execute Pipeline scripts, provide Pipeline step autocompletions, pull Shared Library step documenation, run console groovy scripts across multiple nodes, and more! Honestly, not that much more.
Other
97 stars 32 forks source link

Could not connect to the remote Jenkins when password contains # #41

Closed VitekVlcek-Broadcom closed 3 years ago

VitekVlcek-Broadcom commented 3 years ago

When a password starts with # then I get Could not connect to the remote Jenkins

Developer console reveals

Using the following URI for Jenkins client: http://abc123:#password+-@jenkins3.acme.net
console.ts:137 [Extension Host] Refreshing Pipeline step auto-completions.
console.ts:137 [Extension Host] RequestError: Error: getaddrinfo ENOTFOUND abc123 
   at new RequestError (/home/XXX/.vscode-server/extensions/tabeyti.jenkins-jack-1.1.0/node_modules/request-promise-core/lib/errors.js:14:15)   
   at Request.plumbing.callback (/home/XXX/.vscode-server/extensions/tabeyti.jenkins-jack-1.1.0/node_modules/request-promise-core/lib/plumbing.js:87:29)

There is a workaround: When I replace # with %23 in password in settings.json, then I can connect.

tabeyti commented 3 years ago

Hey @VitekVlcek-Broadcom

This should now be fixed in 1.1.1. If you could please validate the fix for me, I'd appreciate it.

VitekVlcek-Broadcom commented 3 years ago

yes, 1.1.1 fixes it.