search

tabkit / tabkit2

A great Firefox extension edited from Tab Kit
GNU General Public License v2.0
49 stars 8 forks source link

Issues with fullscreen in Pale Moon 28 #145

Open EbonJaeger opened 6 years ago

EbonJaeger commented 6 years ago

In Pale Moon 28, the event model for going to/from fullscreen changed. This causes issues with the auto-hiding of the tab bar; the bar is not hidden after entering fullscreen, and then it is hidden when exiting fullscreen.

On the Pale Moon forums I was linked to this PR which may be of some use: https://github.com/MoonchildProductions/UXP/pull/313

PikachuEXE commented 6 years ago

Oh, let me try to restore the option for full screen this weekend...

EbonJaeger commented 6 years ago

That would be awesome! I have a feeling there's a few other issues with this update as well, if you'd like more issues. xD

This version is a bit of a jump.

EbonJaeger commented 6 years ago

The preference that was re-added seems to work on PM 28; the tab bar seems to hide on fullscreen videos now. However, this exposes a different problem: when fullscreen, all that appears on the screen is this: pm_tabkit2_fullscreen_1

I think I saw this occur on PM 27 too, so I suspect this is part of a different issue. If you want, I can file it separately to keep track of things.

PikachuEXE commented 6 years ago

Where do I find PaleMoon 28 though?

EbonJaeger commented 6 years ago

Windows: https://www.palemoon.org/unstable/ Linux: https://linux.palemoon.org/download/unstable/

PikachuEXE commented 6 years ago

Let me try it next weekend

EbonJaeger commented 6 years ago

No worries. I'd help, but I wouldn't quite know where to start. I'm still trying to learn the NoSquint codebase. Heh.

PinkCathodeCat commented 6 years ago

Was there any progress on this? It still happens on palemoon 28, with an i3 window manager.

PikachuEXE commented 6 years ago

OK 28 stable is out, time to start working :3

PikachuEXE commented 6 years ago

0.13.3 released for Palemoon 28