tablacus / TablacusExplorer

A tabbed file manager with Add-on support
https://tablacus.github.io/explorer_en.html
MIT License
979 stars 102 forks source link

Patched version - WebView2 #740

Open Leo9idas opened 8 months ago

Leo9idas commented 8 months ago

OS info : TE64 24.2.27 Microsoft Windows 11 Pro 64-bit 23H2 (10.0.22631) Dark WebView2/123.0.2420.65 JS/Chakra.dll en_us 96

There is a problem with webview2 and the patched version. Steps to reproduce the behavior :

ccfs commented 8 months ago

What do you get if you repeat the same steps on OFFICIAL VERSION (TE and add-ons) ?

Leo9idas commented 8 months ago

What do you get if you repeat the same steps on OFFICIAL VERSION (TE and add-ons) ?

In the official version everything works as intended

ccfs commented 8 months ago

What if you repeat the same steps on patched version but with WebView2 disabled?

Leo9idas commented 8 months ago

I already did :) With webview2 disabled everything works. Probably webview2 is not included in this patch for 24.2.27 patched version.

ccfs commented 8 months ago

Which "cascaded menu" do you refer to? The menu (of folders and files) shown after clicking the v drop-down button, or the menu (of tool bar items) you made by enclosing items with a Menus/Open and Menus/Close pair?

Can you show me some screen captures of the menu and the error message box?

Besides, from which bar (position) is the menu - default position (with circule filled on Position tab) or others (not filled, i.e. a second tool bar)?

Leo9idas commented 8 months ago

-webview toolbar settings -webview toolbar settings no-webview_cascaded menu no-webview_cascaded menu no-webview_popup no-webview_popup -webview_popuponclick -webview_popuponclick -webview_popup-position-after-forced-update -webview_popup-position-after-forced-update

ccfs commented 8 months ago

Please replace linkbar/toolbar and options.js in script folder with this.

I have changed those parts which might cause the problems. Since I am on Windows 7, I cannot install Edge and WebView2. I cannot test whether the updates will work. Please let me know the result at your side. Thanks.

Leo9idas commented 8 months ago

I tested with the new trial but the same thing happens. The strange thing is that now happens with the normal version !!! I think it is not a problem with linkbar/toolbar specifically. It is a problem with webview2 and the recent updates microsoft released. I tested it also in a windows sandbox and it seemed to work ok but after a webview2 version installed the problems began ! Tested also in a windows 10 installation of mine... the same. Thank you for your efforts but I think I will stop using webview for now. It would be good if someone else shared their experience. Is it only me that has this problem ? Thank you !

ccfs commented 8 months ago

I think that there are 2 problems: (1) On Options page, record details are not refreshed to the selected item on the list. (2) "View" menu problem - "Unable to get property 'x' of undefined or null reference" or off position.

[A] Do both problems happen on the normal version?

[B] I find that the version of TE WebView2 on download page https://tablacus.github.io/tewv2.html is 24.1.9, but on release page https://github.com/tablacus/TablacusExplorerWebView2/releases is 24.3.9. Can the newer release solve any one of the problems on the normal version?

[C] Do the trial solve any one of the problems?

[D] With WebView2 disabled, do the trial cause any new problem on Windows 10/11?

Thanks.

Leo9idas commented 8 months ago

A. (1) record details are refreshing (2) is happening. (if I click in folder view on a file to register position there is no error but dropdown stays at the file. (B) I update webview inside the add-on so it downloads version 24.3.9. (Microsoft update I think is newer than the addon compile) (C) + (D) Trial is working excellent for me in the patched version (24.2.27) with no webview2 of course. Thank you again for looking into the matter.

ccfs commented 6 months ago

The problems have been solved with the latest patch (2024/5/9).

Leo9idas commented 6 months ago

The problems have been solved with the latest patch (2024/5/9).

I thought this was unsolvable but "in Tablacus we Trust" !!!! Thank you !