tablacus / TablacusExplorerAddons

Add-ons for Tablacus Explorer
http://tablacus.github.io/TablacusExplorerAddons/
MIT License
86 stars 12 forks source link

Size status bar - Incorrectly shows 0 for opening in new tab #309

Closed ccfs closed 2 years ago

ccfs commented 2 years ago

Please help to solve this problem. Thanks.

The add-on incorrectly shows 0 as the total file size if a folder is opened in a NEW TAB (the problem does not happen if the folder is opened in current tab). 20211227_122833 20211227_122809

ccfs commented 2 years ago

I have tried the new version 1.23. It can solve the problem only when address bar is used for navigation. It very often does not work if you navigate using the Enter, Ctrl+Enter, Alt+Left and Alt+Right keys. 20211228_111937 20211228_112414 20211228_112453 20211228_112957

ccfs commented 2 years ago

Besides, if BOTH "Folder" and "Total file size" options are ticked, this add-on will show the total size of the WHOLE FOLDER BRANCH when no item is selected. This means that it will go through the whole hard drive when a user navigates to C:\. This is a SERIOUS PERFORMANCE ISSUE.

Therefore I suggest that "Total file size" option should mean ALL FILES and NO FOLDER. Then when a user navigates to a folder, this add-on will show the total size of all files in the folder, but not sub-folders. If the user really wants the whole, he/she should select all items manually.

Regards,

ccfs commented 2 years ago

I have tried the new version 1.24. "Total file size" option has been changed as suggested. However the display just after navigation is still in trouble.

20211229_141325 20211229_141418 20211229_141505 20211229_141553 20211229_141801

ccfs commented 2 years ago

The problems are solved in the new version 1.25. Thanks.