tablacus / TablacusExplorerAddons

Add-ons for Tablacus Explorer
http://tablacus.github.io/TablacusExplorerAddons/
MIT License
87 stars 12 forks source link

Favorites bar / Side tree view - Hint about Height #349

Closed ccfs closed 1 year ago

ccfs commented 1 year ago

This proposed enhancement (see https://github.com/tablacus/TablacusExplorer/issues/633) is to provide users a hint about the input format of "Height" through a placeholder "Number or Percent%":

fb stv

similar to "Auto update" add-on: au

@tablacus and @bblackmoor, please help to make the change. Thanks.

bblackmoor commented 1 year ago

I have created a fork, and I will dig into the code and look for this.

bblackmoor commented 1 year ago

I have found the code that creates that "Height" control. That is a straightforward edit.

However, neither the "Favorites Bar" addon nor the "Side Tree View" addon are in the main TablacusExplorer git repo. I do not know where they are. I do not see a git url on either page.

https://tablacus.github.io/wiki/addons/favoritesbar.html https://tablacus.github.io/wiki/addons/sidetreeview.html

I am open to suggestions.

ccfs commented 1 year ago

I think the repo is https://github.com/tablacus/TablacusExplorerAddons. I am not a developer and I don't know the process to make a change.

The "Height" text box also appears in other places of TE and some other add-ons, but only the above 2 accept either a number or a percentage and have to be enhanced.

bblackmoor commented 1 year ago

Yes! I have forked that repo, and found the "Favorites Bar" addon and the "Side Tree View" addon. I will make the needed changes.

bblackmoor commented 1 year ago

I made the edit and pushed them to my fork. I am not sure what to do next. I clicked the"Contribute" button, and got the following response from it. I do not know what to do with this.

image

ccfs commented 1 year ago

The new version is OK. Thanks.