Sync select - "Extension" option should be ignored for folders

[ccfs]

Folders do not have "extension", but the add-on cannot handle this correctly. @bblackmoor and @tablacus, please help to solve this problem. Thanks.

[bblackmoor]

I tested this in my sandbox. My tests show:

1) When "File extension" (NOTE: This is not a clear label in English. Inverting the logic and labeling it "Ignore extension" would be clearer, and more intuitive.) is selected (the default):

"TablacusExplorer" and "TablacusExplorerAddons" are selected. "TablacusExplorer.old" is not. This is as expected.

2) When "File extension" (see note above) is not selected:

"TablacusExplorer", "TablacusExplorer.old", and "TablacusExplorerAddons" are selected. This is as expected.

The setting appears to be functioning as expected.

If I appear to have misunderstood something, please let me know.

[ccfs]

"File extension" is the string after the last dot of the name of a FILE. It indicates a file type and the associated application. However FOLDER is a type itself. Anything in the name, including any dot, is the name.

Therefore in my example above, it is correct for "file.v2" but incorrect for "folder.v2".

[bblackmoor]

A directory is a unique type of file that contains only the information needed to access files or other directories. The extension is just part of the name. The add-on appears to be functioning as expected.

[bblackmoor]

Besides, what would be the alternative? That the extension is always ignored for directories? Even if the extension on a file was somehow different from the extension on a directory (it's not), is that a reason to remove the choice whether to ignore the extension on directories?

[ccfs]

What I stated is the Microsoft's definition of "file extension". Of course some people may have a different understanding. Whatever. Users can try ticking or clearing the option to fit their needs.

So we can keep the add-on unchanged. Thanks.