search

tablacus / TablacusExplorerAddons

Add-ons for Tablacus Explorer
http://tablacus.github.io/TablacusExplorerAddons/
MIT License
87 stars 12 forks source link

Script Error with Background Image addon on startup #369

Closed TheMidnightSnack closed 7 months ago

TheMidnightSnack commented 8 months ago

Hello, With the Background Image addon enabled, I receive a script error when opening TE.

Untitled

The background image also disappears when leaving and returning to the directory. I am unsure if this is a bug or just the nature of the addon.

Running: TE64 23.9.13 Microsoft Windows 10 Pro 64-bit 22H2 (10.0.19045) IE/11 JS/11.0.16384 en_us 96 AMD Ryzen 7 5700X 8-Core Processor Windows Defender

with Addons: bgimage 1.09,tabdesign 1.16,mouse 1.33,key 1.26,addressbar 1.71,filterbar 1.39,back 1.18,forward 1.18,up 1.20,treeview 1.44,refresh 1.10,toolbar 1.44,mainmenu 1.16,titlebar 1.09,tabplus 1.96,multithread 1.29,remember 1.42,undoclosetab 1.16,aboutblank 1.04,foldericon 1.04,classicstyle 1.10,openinstead 1.13,stripeslite 1.09,tasktray 1.15,startup 1.11,framepane 1.02

ccfs commented 7 months ago
  1. Script error: I cannot reproduce the error. Anyway I have made a change according to a probable cause.
  2. Background image disappeared: I have made a change.

Pleases try this patch and see.

ccfs commented 7 months ago

This revised patch may be better. Please let me know the result. Thanks.

TheMidnightSnack commented 7 months ago

The patch you provided has fixed the disappearing background issue well. However, I am now receiving this error:

Untitled

After experimenting with disabling my other addons, I found the error only appears when the Startup Settings addon is enabled with the option of 'Close other tabs', as described by @tablacus in https://github.com/tablacus/TablacusExplorerAddons/issues/25#issuecomment-371120543

asd

The two addons seem to be conflicting each other at startup.

ccfs commented 7 months ago

I have further revised the patch. The above problem should be solved.

TheMidnightSnack commented 7 months ago

Issue resolved, patch works well.

ccfs commented 4 months ago

I have updated the patch since the previous one gets an error under WebView.