tablacus / TablacusExplorerIconPacks

Icon packs for Tablacus Explorer
MIT License
1 stars 1 forks source link

Tablacus Light Icon Pack #3

Open duarteframos opened 3 years ago

duarteframos commented 3 years ago

Hey @tablacus so I started working on the first stub of what I hope will become the future default theme.

Default icon pack for light colors. Preview

Icons can be easily colored differently for different UI themes, like a dark colored/night mode. PreviewA PreviewB PreviewC PreviewD

I though about the preview images further and didn't consider including a screenshot of the window before. There are 640 x 400 pixels, and seem adequate, what do you think?

It doesn't include all icons from the Microsoft libraries, some I don't think are ever used in TE, others I couldn't figure out what they meant. There are the ones I designed, some (like Toggle Tree and New Tab)were adapted for TE specific use, if more are needed let me know.

Tablacus_Light

The old thread can be closed I think, discussion may continue here on a per icon pack or issue basis.

Let me know what you think and what needs changes.

tablacus commented 3 years ago

The icon selection screen looks like this. image

Click on 24px General image

Click on 24px Browser image

The download & install screen is going to take a little longer.

Regards,

tablacus commented 3 years ago

My preview image is like placing some typical icons in a rectangle. It looks like the following.

image

Regards,

duarteframos commented 3 years ago

My preview image is like placing some typical icons in a rectangle.

Ah yes much simpler and easier to achieve. I reformulated my preview images to follow your guidelines came up with a 256 x 160px size preview. What do you think, is that a good size?

Those icon selection screenshots looks cool too. I see now that most icons got an unintended white backdrop, that was not intentional, needs cleanup.

duarteframos commented 3 years ago

I've created a new pull request with updated icons, tweaked a few of the existing ones for better appearance, and removed the white background for full transparency. Also added a new matching dark icon pack for night modes.

Let me know what you think, feel free to tell if you think any icons need adjustments or are not clear. Also let me know if it is worth it making a rainbow-selection of matching colored icon packs based on the current as illustrated above.

tablacus commented 3 years ago

I think the preview size you suggested is good, but please consider it again when you have an installation page.

As I found out as I was building it, the following part of config.json is not currently in use and can be omitted.

    "icons": {
      "general": {
        "size": 64,
        "max": 43
      },
      "browser": {
        "size": 64,
        "max": 12
      },
      "shell32": {
        "size": 64,
        "max": 0
      }

Regards,

duarteframos commented 3 years ago

I think the preview size you suggested is good, but please consider it again when you have an installation page.

I can easily adjust once you get the gallery up and running, and adapt to whatever size is required.

As I found out as I was building it, the following part of config.json is not currently in use and can be omitted.

    "icons": {
      "general": {
        "size": 64,
        "max": 43
      },
      "browser": {
        "size": 64,
        "max": 12
      },
      "shell32": {
        "size": 64,
        "max": 0
      }

Regards,

Will remove on next update, thanks

tablacus commented 3 years ago

I have a few requests. I want preview.png to be lowercase. Add the id to config.json. The id is the same as the folder name. Tablacus_Dark etc.

https://github.com/tablacus/TablacusExplorerIconPacks

Regards,

duarteframos commented 3 years ago

Hey the new UI looks great, didn't expect to see it working in such short notice, great work. I've updated the icon packs as requested, preview.png is now lower case, added id to config.json

duarteframos commented 3 years ago

@tablacus I've made a few additions and changes to the icon pack.

  1. Can we use alphanumeric names for png icons in other folders? I've created a few misc category for a few upcoming changes, it'd be more convenient to have readable names, is this possible?
  2. Tree icon now uses shell32/41.png (before it was general/43.png), can you update in the UI for toolbar toggle tree button? That matches better with the original Microsoft designs.
  3. New Tab button which was before general/12.png has been moved to shell32/295.png or misc/new_tab.png to better match Microsoft. Will this cause trouble, can you update?
  4. I've added shell32/71.png for Options/Settings icon, so you can use it for the addon Options button and elsewhere.
  5. I've added shell32/289.png for tags (I think I've seen it used somewhere in the UI) and shell32/304.png for future use.
tablacus commented 3 years ago
  1. please try to install Tablacus Explorer 20.9.23.

Regards,

duarteframos commented 3 years ago

Tree icon seems to be working well, not sure if you are using the one from misc already.

The dark preview is still using the old image, but github was stubbornly still showing the older one despite me uploading several times. I've made a pull request with an updated image, not sure it made it through this release yet.

The New Tab icon for the Simple Toolbar addon needs updating to show shell32/295.png or misc/new_tab.png, it is currently showing an icon for "Browse"

There is now an icon at shell32/289.png for the Label Button addon if you wish. TE

Other than tah seems to be working well. Thanks for the hardwork

duarteframos commented 3 years ago
  1. please try to install Tablacus Explorer 20.9.23.

Didn't get what you meant yesterday, but yes custom icons with alphanumeric names seem to be working correctly. Custom Alphanumeric Icons Successfully tested today by adding a button with a custom icon to the toolbar.

Now the only needed adjustments now are changing:

  1. Default icons for New Tab icon for the Simple Toolbar to show shell32/295.png or misc/new_tab.png
  2. Tree icon to shell32/41.png
  3. Optionally use shell32/289.png for the Label Button addon.

Thanks