search

table-library / react-table-library

:bento: React Table Library
https://react-table-library.com
MIT License
715 stars 43 forks source link

Support for CommonJS #104

Open NiclasThobaben opened 1 year ago

NiclasThobaben commented 1 year ago

Hi, do you plan on supporting a commonJS build of the library or will it stay pure ESM?

rwieruch commented 1 year ago

I didn't plan to support it. Can't you use ESM in your project?

NiclasThobaben commented 1 year ago

We do. However, we use some tools, like Jest, which rely on CommonJS. For Jest this is not a huge problem, as it support transformation of dependencies, before execution, but other tools (i.e. cucumber-js) have issues with that.

rwieruch commented 1 year ago

If this is an easy change, feel free to open a PR :)

Audiopolis commented 2 months ago

It should just be this, no?

image