search

table-library / react-table-library

:bento: React Table Library
https://react-table-library.com
MIT License
747 stars 47 forks source link

Remove emotion dependency as many people have moved to Zero-Runtime CSS-in-JS solutions #86

Open sorenhoyer opened 2 years ago

sorenhoyer commented 2 years ago

As more and more people are aware of the costs of runtime css-in-js libraries many people have started migrating away from styled-components, emotion etc. to Zero-Runtime CSS in JS libraries instead. I really wanted to use this library, but the fact that it requires emotion to be installed, is a deal breaker for me - and I'm probably not the only one facing this problem.

While I know you primarily developed this for your own use, may I suggest you remove the dependency on emotion and just stick to normal css or even reacts inline styles, so you leave it up to the user what custom styling solution they want to use.

rwieruch commented 2 years ago

I know the recent trend and I have been aware before it by trying different solutions, however, since all big UI libraries are still using Emotion at this point, I find it okay to install it. However, I have it on the roadmap to make Emotion optional or to remove it entirely. At the moment there are no resources on my side to accomplish this task though.

mschoenebeck commented 9 months ago

+1 to remove emotion as a dependency. It totally conflicts with the way I'm styling my components.

I really appreciate the work but a lightweight library shouldn't have a styling dependency. Now I have to somehow work-around it or (more likely) use a different lib.. :(