Open til-jmac opened 1 year ago
Having the same issue
Hi @jay2610 and @til-jmac ,
Wonder if below work-around would help:
Revert all changes in Logshark/Logshark.csproj locally, and retry build. https://github.com/tableau/Logshark/commit/d0c0ca9076307844e2c686436a6b77b0c680f88b#diff-6fe1e64645078ab18848d369ae5ee3d3f9ff22943ae39c5a84d61f087635daeb
We might be releasing a patch for this in the coming weeks.
@til-jmac This is due to a missing manual step in the release process. Those changes should not have been there in the 4.2.3 release.
@til-jmac This is due to a missing manual step in the release process. Those changes should not have been there in the 4.2.3 release.
Thanks for the reply. Reverting the changes locally does work, just wanted to raise it so a fix can be incorporated.
any update here ? or more detail on how to update locally?
any update here ? or more detail on how to update locally?
Open Logshark/LogShark.csproj and add this after the last </ItemGroup>
(for me this was on line 60)
<ItemGroup>
<Reference Include="Tools.TableauServerRestApi">
<HintPath>..\thirdparty\Tools.TableauServerRestApi.dll</HintPath>
</Reference>
</ItemGroup>
how is this STILL open ??
@zhuoyanggao Since v4.2.3 the docker build process is broken, with the error as described in https://github.com/tableau/Logshark/issues/165
The following commit appears to be the cause: https://github.com/tableau/Logshark/commit/d0c0ca9076307844e2c686436a6b77b0c680f88b#diff-6fe1e64645078ab18848d369ae5ee3d3f9ff22943ae39c5a84d61f087635daeb
Reverting this change so that the package can be found in the relevant path in the source code resolves the issue. Any reason this can't be updated in the latest version so that we can use it in docker?
Credit to @petersilv for spotting this