Clean Up Bare Exception Catching

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:

https://tableau.github.io/TabPy/

MIT License

1.56k stars 598 forks source link

Clean Up Bare Exception Catching #212

Closed WillAyd closed 5 years ago

WillAyd commented 5 years ago

There's quite a few places in the code base where we do except Exception - this can lead to unintended consequences since we are blanket catching any and everything that could happen within the try block.

It's almost always preferable to catch the actual Exceptions instead; will post a list of what is in master after #205 gets merged as this is something that likely will be done in multiple PRs

0golovatyi commented 5 years ago

I believe all except: cases were fixed, closing the issue.