search

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:
https://tableau.github.io/TabPy/
MIT License
1.56k stars 598 forks source link

update pw file parser #244

Closed johng42 closed 5 years ago

johng42 commented 5 years ago

If the password file had a username followed by a space, parsing would succeed and set the user password to null add a check to fail parsing and log a warning about this conditin

pep8speaks commented 5 years ago

Hello @johng42! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-04-04 17:15:27 UTC
0golovatyi commented 5 years ago

Great catch! Can we have a unit test for that?

jnegara commented 5 years ago

Why isn't coverage reflecting the new test?