tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:
https://tableau.github.io/TabPy/
MIT License
1.56k stars 598 forks source link

command updated #278

Closed sulaxd closed 5 years ago

sulaxd commented 5 years ago

Tableau Server 2018.2 (Windows) / Tableau Server 10.5 (Linux) and Newer Versions:

johng42 commented 5 years ago

Build failed - https://travis-ci.com/tableau/TabPy/builds/110331602

More specifically, docs/TableauConfiguration.md: 40: MD013/line-length Line length [Expected: 80; Actual: 106]

so just adjust the length of line 40 to not be more than 80 characters and resubmit.

Thanks for helping!

johng42 commented 5 years ago

Line 36 is still too long: docs/TableauConfiguration.md: 36: MD013/line-length Line length [Expected: 80; Actual: 137]

sulaxd commented 5 years ago

But line 36 I only add “configuration” ..

John notifications@github.com於 2019年5月3日 週五,下午11:30寫道:

Line 36 is still too long: docs/TableauConfiguration.md: 36: MD013/line-length Line length [Expected: 80; Actual: 137]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tableau/TabPy/pull/278#issuecomment-489136191, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMBT7SVOFLF273DMUOUDK3PTRLBDANCNFSM4HJ32XPA .

-- Best regards Andrew T.

0golovatyi commented 5 years ago

@sulaxd As mentioned in contributing guide you can use https://dlaa.me/markdownlint/ to validate documentation format.

sulaxd commented 5 years ago

Ok. I try.

Andrew T sulaxd@gmail.com於 2019年5月3日 週五,下午11:43寫道:

But line 36 I only add “configuration” ..

John notifications@github.com於 2019年5月3日 週五,下午11:30寫道:

Line 36 is still too long: docs/TableauConfiguration.md: 36: MD013/line-length Line length [Expected: 80; Actual: 137]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tableau/TabPy/pull/278#issuecomment-489136191, or mute the thread https://github.com/notifications/unsubscribe-auth/ABMBT7SVOFLF273DMUOUDK3PTRLBDANCNFSM4HJ32XPA .

-- Best regards Andrew T.

-- Best regards Andrew T.

johng42 commented 5 years ago

Thanks for spotting this - good eye.