Remove platform specify logic from deploying models

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:

https://tableau.github.io/TabPy/

MIT License

1.56k stars 598 forks source link

Remove platform specify logic from deploying models #289

Closed sbabayan closed 4 years ago

sbabayan commented 5 years ago

Both in integ_test_base.py and in models/setup.py we check for windows or mac to specify which python to use when running the script files (python3 vs python).

0golovatyi commented 5 years ago

I spent some time looking at other Python projects and it seems like what we do is the same thing other projects do. Unless we start using some library which hides the specifics I think we are good to close this issue.

johng42 commented 5 years ago

Oddly, I spent this morning looking at the same thing. Until debian based distros update their python environments they ship to not include the '3' (or '4' or whatever in the future) there is no other way I could find to work around this.

0golovatyi commented 4 years ago

Closing this as what we have in TabPy code is the same people do in other Python projects.