Closed sbabayan closed 5 years ago
Hello @sbabayan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tabpy-server/tabpy_server/app/app.py
:Line 189:80: E501 line too long (98 > 79 characters) Line 196:80: E501 line too long (103 > 79 characters)
Line 36:80: E501 line too long (112 > 79 characters) Line 84:80: E501 line too long (84 > 79 characters)
tests/integration/integ_test_base.py
:Line 144:80: E501 line too long (93 > 79 characters) Line 150:80: E501 line too long (82 > 79 characters)
tests/integration/test_custom_evaluate_timeout.py
:Line 10:80: E501 line too long (84 > 79 characters) Line 12:80: E501 line too long (123 > 79 characters) Line 22:80: E501 line too long (84 > 79 characters) Line 44:1: W293 blank line contains whitespace
tests/unit/server_tests/test_config.py
:Line 111:80: E501 line too long (105 > 79 characters) Line 124:80: E501 line too long (107 > 79 characters)
We need to delete releases 0.4.1 and 0.5 as they have the bug in them - please update VERSION and changelog.
Closed this pr until we can fix configurable timeout bug, will merge just the models fix to master for now (in a new pr)
fixed bug where we cannot access model from tableau, extended integration test to cover this scenario