Add return None, modify body args - Githubissues

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:

https://tableau.github.io/TabPy/

MIT License

1.56k stars 598 forks source link

Add return None, modify body args #386

Closed phantomcosmonaut closed 4 years ago

phantomcosmonaut commented 4 years ago

Added the 'return None' capability and unit test. Also modified the code around arguments_str = ", " + ", ".join(arguments.keys()) not just because I like one-liners, but because arguments.keys() has not actually been sorted, only a new sorted copy has been created, so the arguments_str could potentially combine dict keys out of order.

pep8speaks commented 4 years ago

Hello @phantomcosmonaut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file tabpy/tabpy_server/handlers/evaluation_plane_handler.py:

Line 70:80: E501 line too long (85 > 79 characters) Line 131:30: W292 no newline at end of file

In the file tabpy/tabpy_tools/client.py:

Line 387:1: W293 blank line contains whitespace Line 387:1: W391 blank line at end of file

In the file tests/unit/server_tests/test_evaluation_plane_handler.py:

Line 216:49: W292 no newline at end of file

Comment last updated at 2019-12-21 23:18:32 UTC

0golovatyi commented 4 years ago

Test failures - https://travis-ci.com/tableau/TabPy/builds/141996187

phantomcosmonaut commented 4 years ago

Yep I saw that, I'll fix it