Closed phantomcosmonaut closed 4 years ago
Hello @phantomcosmonaut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Line 70:80: E501 line too long (85 > 79 characters) Line 131:30: W292 no newline at end of file
tabpy/tabpy_tools/client.py
:Line 387:1: W293 blank line contains whitespace Line 387:1: W391 blank line at end of file
Line 216:49: W292 no newline at end of file
Test failures - https://travis-ci.com/tableau/TabPy/builds/141996187
Yep I saw that, I'll fix it
Added the 'return None' capability and unit test. Also modified the code around
arguments_str = ", " + ", ".join(arguments.keys())
not just because I like one-liners, but because arguments.keys() has not actually been sorted, only a new sorted copy has been created, so the arguments_str could potentially combine dict keys out of order.