Closed phantomcosmonaut closed 4 years ago
Hello @phantomcosmonaut! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
@phantomcosmonaut There are still pep8 warnings in your code change. I would fix those myself but don't have access to your branch.
How do you handle the merge conflicts between the dev and the master branch when both are being edited?
@phantomcosmonaut We will take care of it :) The process is we merge from master to dev first, resolve any conflicts and then open PR dev->master.
Improvements from my last pull but I put simplejson back and fixed the new unit test