Closed GavinYang-LR closed 3 years ago
@GavinYang-LR Looks like a bug, thanks for reporting.
@0golovatyi Hi Could you make a hotfix for this? I want to do but, don't have permission to push a branch.
@GavinYang-LR You can create a merge request from your fork to the master branch.
I will try to work on it this week, but can't really promise.
@GavinYang-LR I prepared this fix - https://github.com/tableau/TabPy/pull/462. If you could confirm it works for you.
@GavinYang-LR I just published pre-release version of TabPy with the fix in it. You can update to it with pip install --upgrade -i https://test.pypi.org/simple/ tabpy
command.
Let me know if it worked for you.
Published tabpy 2.3.1 with the fix, closing the issue.
@0golovatyi Hey man, Sorry missed tons of comments, going to test with the team today, appreciate hard work this week. Thanks
When I deploy the same function in override mode, the error will raise
I checked the code, when we first deploy the function the service will run
_check_and_set_target(param,'')
https://github.com/tableau/TabPy/blob/a45b4671ddbb74917ebf19be610e7c65bad7f833/tabpy/tabpy_server/management/state.py#L235 When we deploy override mode, the TabPy service will run_check_and_set_target(param, None)
https://github.com/tableau/TabPy/blob/a45b4671ddbb74917ebf19be610e7c65bad7f833/tabpy/tabpy_server/management/state.py#L334 I realized that it will fail anyway, otherwise something wrong in my config?