search

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:
https://tableau.github.io/TabPy/
MIT License
1.55k stars 592 forks source link

Accept proxy setting in tabpy-deploy-models #467

Open ElPincheTopo opened 3 years ago

ElPincheTopo commented 3 years ago

tabpy-deploy-models runs SentimentAnalysis.py which runs:

nltk.download("vader_lexicon")
nltk.download("punkt")

This fails if you are running in environments without direct connection to the internet. nltk supports setting a proxy for the downloads, so I propose adding a cmd line argument to pass the proxy address to tabpy-deploy-models and this would pass it to all the scripts in case any other script needs it. For now, only SentimentAnalysis.py and we just need to get the cmd arg pass it to nltk.set_proxy().

I'm happy to do this but I would like to know if the team behind TabPy likes the approach and would accept my Pull request.

0golovatyi commented 3 years ago

@ElPincheTopo Yes, the team behind TabPy would love any improvements!

ElPincheTopo commented 3 years ago

I submitted a pull request with my proposed changes: https://github.com/tableau/TabPy/pull/471

nmannheimer commented 2 years ago

It's taken some time, but we are reviewing this now.