search

tableau / TabPy

Execute Python code on the fly and display results in Tableau visualizations:
https://tableau.github.io/TabPy/
MIT License
1.56k stars 598 forks source link

PyPI sdist doesnt contain resources #472

Closed jayvdb closed 3 years ago

jayvdb commented 3 years ago

Environment information:

Describe the issue The sdist on PyPI includes tests, however the resources are not present, which means many tests fail trying to open tests/integration/resources/pwdfile.txt and similar

0golovatyi commented 3 years ago

@jayvdb what are repro steps for tests to fail?

jayvdb commented 3 years ago
  1. Fetch https://files.pythonhosted.org/packages/5d/9e/c653c26ea1d852bd4d17aca77702543edbae438a61d290c4a871080b8e0b/tabpy-2.3.1.tar.gz
  2. Unpack into a temp dir
  3. Activate new venv
  4. Install into new venv
  5. run tests from the temp dir
0golovatyi commented 3 years ago

@jayvdb Thank you for the steps, now I got it. Using tar.gz is not something we see people do - usually, they just fork the repo, make changes and create merge request.

Approving you merge reques.