Closed jakeichikawasalesforce closed 4 months ago
Hello @jakeichikawasalesforce! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
tabpy/tabpy_server/app/app.py
:Line 99:1: W293 blank line contains whitespace Line 100:65: W291 trailing whitespace
tests/integration/test_minimum_tls_version.py
:Line 4:1: E302 expected 2 blank lines, found 1 Line 15:99: E501 line too long (99 > 98 characters) Line 31:1: E302 expected 2 blank lines, found 1 Line 39:1: E302 expected 2 blank lines, found 1 Line 48:1: E302 expected 2 blank lines, found 1
Adding a TabPy config parameter to set the minimum TLS version (TABPY_MINIMUM_TLS_VERSION) that the server will accept for secure connections. By default, the minimum TSL version will be set to TLSv1_2. See https://docs.python.org/3/library/ssl.html#ssl.TLSVersion.MINIMUM_SUPPORTED.
Other changes:
macos-latest@arm64
in Rest Runs.utcnow()
instead ofnow()
when validating certificates (fix for self-signed certificates).