tableau / VizAlerts

Data-driven alerting for Tableau Server
MIT License
211 stars 91 forks source link

Review code for platform-specific file paths #194

Open mcoles opened 2 years ago

mcoles commented 2 years ago

Linux users encounter friction because VizAlerts was developed and tested on Windows, and uses Windows conventions for filepaths.

Examples are several config file values:

https://github.com/tableau/VizAlerts/blob/master/config/vizalerts.yaml#L2 https://github.com/tableau/VizAlerts/blob/master/config/vizalerts.yaml#L5 https://github.com/tableau/VizAlerts/blob/master/config/vizalerts.yaml#L6

Here's one hard-coded in the executable script itself:

https://github.com/tableau/VizAlerts/blob/master/vizalerts.py#L84

We should do a search for all references to platform-specific paths and render them platform-agnostic. At the very least the config file should also be commented to provide instructions for Linux users.

Reference: https://community.tableau.com/s/question/0D58b00009WrPcNCAV/