Add support for null oauth config in packager

tableau / connector-plugin-sdk

SDK for Developing Tableau Connector Plugins

https://tableau.github.io/connector-plugin-sdk/

MIT License

108 stars 108 forks source link

Add support for null oauth config in packager #1170

Closed pvanderknyff closed 1 year ago

pvanderknyff commented 1 year ago

Tacos with null OAuth config are packaged
min_tableau_version set to 2024.1 (can always update if we backport)
Adds a new test, confirmed all other tests pass

salesforce-cla[bot] commented 1 year ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Patrick VanderKnyff p***@s***.com. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

rosswbrown commented 1 year ago

Change looks good, but should we target dev-2024.1 (doesn't exist yet) branch instead?

pvanderknyff commented 1 year ago

Think it's fine in the main branch since the resultant taco is already blocked on 2024.1. People won't be able to use the changes to make a taco that works on versions not supported by 2024.1. Plus, there was talk of backporting once release freeze is over.