search

tableau / connector-plugin-sdk

SDK for Developing Tableau Connector Plugins
https://tableau.github.io/connector-plugin-sdk/
MIT License
108 stars 108 forks source link

Staples test for MONTH() seems to have incorrect expected result #1176

Closed GumpacG closed 1 year ago

GumpacG commented 1 year ago

About You: Name: Guian Gumpac Company: Improving

Your question: Why is the expected for SELECT MONTH(`Staples`.`Order Date`) a column of 1s when it should be 5s and 6s?

The test case Filter.slicing_Q_date_month_instance_filter has expected result and generated SQL:

Expected (100)tuples
1
1
1
1
1
1
1
1
1
...
SELECT MONTH(`Staples`.`Order Date`) AS `mn_Order Date_qk`
FROM `staples` `Staples`

I get a failure because the actual is a column of 5s. For context I run the query:

SELECT MONTH(`Staples`.`Order Date`), `Staples`.`Order Date`
FROM `staples` `Staples`

and get this result:

fetched rows / total rows = 200/200
+---------------------------------+---------------------+
| MONTH(`Staples`.`Order Date`)   | Order Date          |
|---------------------------------+---------------------|
| 5                               | 2002-05-24 00:00:00 |
| 5                               | 2002-05-24 00:00:00 |
| 5                               | 2002-05-24 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-25 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-26 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-27 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-28 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-29 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-30 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 5                               | 2002-05-31 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-01 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-02 00:00:00 |
| 6                               | 2002-06-03 00:00:00 |
| 6                               | 2002-06-03 00:00:00 |
| 6                               | 2002-06-03 00:00:00 |
| 6                               | 2002-06-03 00:00:00 |
| 6                               | 2002-06-03 00:00:00 |
+---------------------------------+---------------------+
lukewrites commented 1 year ago

Internal tracking: W-14125655

rosswbrown commented 1 year ago

The Filter.slicing_Q_date_month_instance_filter tests the Tableau DATEPART('month', [Order Date])` function.

The expected file shows that all values 1 through 12 are expected.

I'd recommend looking in the dialect definition of the DATEPART function to verify that looks correct for your underlying data source. Example:

<date-function name='DATEPART' return-type='int'>
  ...
  <formula part='month'>MONTH(%2)</formula> // example
  ..
  <argument type='localstr' />
  <argument type='datetime' />
</date-function>
GumpacG commented 1 year ago

Will take a look further. Thanks!