pep8speaks
commented
9 months ago Thanks for updating the PR.
- In the file
tdvt/tdvt/config_gen/datasource_list.py:
Line 382:121: E501 line too long (122 > 120 characters) Line 239:1: E122 continuation line missing indentation or outdented
- In the file
tdvt/tdvt/config_gen/test_config.py:
Line 256:10: E124 closing bracket does not match visual indentation Line 125:90: E221 multiple spaces before operator Line 125:13: F405 'logging' may be undefined, or defined from star imports: ..resources Line 60:18: F405 'get_resource_full_path' may be undefined, or defined from star imports: ..resources Line 58:16: F405 'get_resource_full_path' may be undefined, or defined from star imports: ..resources
- In the file
tdvt/tdvt/setup_env.py:
Line 311:20: W292 no newline at end of file Line 301:66: E231 missing whitespace after ',' Line 301:35: F405 'get_root_dir' may be undefined, or defined from star imports: .resources Line 300:8: F405 'get_root_dir' may be undefined, or defined from star imports: .resources Line 290:1: E302 expected 2 blank lines, found 1 Line 284:19: E713 test for membership should be 'not in' Line 269:24: W605 invalid escape sequence '\s' Line 268:24: W605 invalid escape sequence '\s' Line 267:24: W605 invalid escape sequence '\s'
- In the file
tdvt/tdvt/tabquery_path.py:
- In the file
tdvt/tdvt/tdvt.py:
Line 869:5: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 788:5: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 763:5: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 632:5: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 629:17: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 627:25: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 623:50: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 623:5: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 499:40: W291 trailing whitespace Line 499:30: W605 invalid escape sequence '_' Line 498:40: W291 trailing whitespace Line 498:29: W605 invalid escape sequence '\ ' Line 497:40: W291 trailing whitespace Line 497:30: W605 invalid escape sequence '\ ' Line 497:28: W605 invalid escape sequence '\ ' Line 496:29: W605 invalid escape sequence '\ ' Line 496:27: W605 invalid escape sequence '\ ' Line 495:41: W291 trailing whitespace Line 443:121: E501 line too long (134 > 120 characters) Line 442:1: W293 blank line contains whitespace Line 390:13: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 220:9: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 219:9: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 99:13: F405 'logging' may be undefined, or defined from star imports: .tabquery Line 60:13: F405 'logging' may be undefined, or defined from star imports: .tabquery
- In the file
tdvt/tdvt/tdvt_core.py:
Line 390:6: F405 'TestResult' may be undefined, or defined from star imports: .resources, .test_results Line 385:1: E302 expected 2 blank lines, found 1 Line 358:24: F405 're' may be undefined, or defined from star imports: .resources, .test_results Line 357:24: F405 're' may be undefined, or defined from star imports: .resources, .test_results Line 352:1: E302 expected 2 blank lines, found 1 Line 341:1: E302 expected 2 blank lines, found 1 Line 218:121: E501 line too long (127 > 120 characters) Line 65:17: F405 'get_logical_test_file_paths' may be undefined, or defined from star imports: .resources, .test_results
- In the file
tdvt/test/tdvt_test.py:
Line 1278:10: F405 'TestResult' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results Line 1270:60: F405 'TestErrorSkippedTest' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results Line 1264:60: F405 'TestErrorDisabledTest' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results Line 1245:28: F405 'TdvtInvocation' may be undefined, or defined from star imports: tdvt.tabquery, tdvt.test_results Line 1243:9: F841 local variable 'error_message' is assigned to but never used Line 1237:121: E501 line too long (193 > 120 characters) Line 1232:121: E501 line too long (179 > 120 characters) Line 1228:121: E501 line too long (188 > 120 characters) Line 1227:121: E501 line too long (185 > 120 characters) Line 1222:121: E501 line too long (129 > 120 characters) Line 1219:121: E501 line too long (198 > 120 characters) Line 1218:121: E501 line too long (195 > 120 characters) Line 1213:121: E501 line too long (133 > 120 characters) Line 1206:1: E302 expected 2 blank lines, found 1 Line 1190:121: E501 line too long (178 > 120 characters) Line 1183:1: E302 expected 2 blank lines, found 1 Line 406:121: E501 line too long (128 > 120 characters) Line 383:121: E501 line too long (133 > 120 characters) Line 369:121: E501 line too long (133 > 120 characters) Line 359:121: E501 line too long (133 > 120 characters) Line 344:121: E501 line too long (133 > 120 characters) Line 19:1: F401 're' imported but unused
Bring all internal changes external for new version of tdvt.
@tabsdavis and @madhurabha please verify that your PRs looks good in here. Thanks! 😄
If you see anything that isn't right, please mention it here and add it to
Issue #1on the internal repo.Closes: #1179