search

tableau / connector-plugin-sdk

SDK for Developing Tableau Connector Plugins
https://tableau.github.io/connector-plugin-sdk/
MIT License
105 stars 107 forks source link

[BUG] GetProductName return Tableauserver for TableauCloud #1212

Closed eric-wang-1990 closed 1 day ago

eric-wang-1990 commented 6 months ago

Thanks for filing a bug report! Please check out our docs on Filing a Bug with the SDK for guidance on what to include with your report.

Describe the bug As listed here https://tableau.github.io/connector-plugin-sdk/docs/api-reference.html the GetProductName should return TableauCloud for TableauCloud, but as our tests it just return TableauServer.

Screenshots If applicable, add screenshots to help explain your problem.

image

agent captured: "thriftUserAgent":"SimbaSparkODBCDriver/2.7.5.1012 Thrift/0.9.0 (C++/THttpClient) TableauServer/2024.1.0"

Desktop (please complete the following information):

About you: Name: Eric Wang Company: Databricks

lukewrites commented 6 months ago

Nice Issue number, @eric-wang-1990 😄

Internal tracking: W-14869726

pvanderknyff commented 3 months ago

Hi Eric,

Taking a look at this. GetProductName logic looks sound, investigation will probably take a while longer since we most likely will need to add some logging to cloud to track this down.

For context, are you always seeing "Tableau Server"? Or do you sometimes see "Tableau Cloud"?

eric-wang-1990 commented 3 months ago

Hi Eric,

Taking a look at this. GetProductName logic looks sound, investigation will probably take a while longer since we most likely will need to add some logging to cloud to track this down.

For context, are you always seeing "Tableau Server"? Or do you sometimes see "Tableau Cloud"?

We only see Tableau Server, Tableau Desktop, Tableau. We never see Tableau Cloud.

pvanderknyff commented 1 day ago

Hi Eric, thanks for your patience. The investigation took longer than expected, your issue uncovered an underlying problem that one process was not correctly being labeled as "Tableau Cloud" on startup. We've fixed this on our end, and GetProductName should be returning the correct value now (or very soon, depending on when the next Cloud update is). Closing this issue as fixed, please reopen if you're still not seeing Tableau Cloud as a result.