search

tableau / document-api-python

Create and modify Tableau workbook and datasource files
https://tableau.github.io/document-api-python/
MIT License
326 stars 178 forks source link

Update field.py #215

Closed rimishra-equinix closed 2 years ago

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @rimishra-equinix to sign the Salesforce.com Contributor License Agreement.

rimishra-equinix commented 2 years ago

Added code to get info if the fields is hidden or not

dev-mkc19 commented 2 years ago

It also recommended to provide tests and update documentation.

rimishra-equinix commented 2 years ago

It also recommended to provide tests and update documentation.

Thank you Mikhail for your feedback. However, I am very new to Python and GIT have been self-learning Python. I have written the Python code to extract similar information including additional data like if the field is hidden or not, and wanted to add that capability in the document-api. I am not sure how can I test the dev branch and it will be helpful if we can get on a call and you can walk me through that?

dev-mkc19 commented 2 years ago

@rimishra-equinix You can write simple unit tests (see example in test folder) that will confirmed everything works as expected. It will help in future to add new functionality and be sure that nothing was broken. I'm sure you can, it's easy.

Changing documentation it's easy too. Edit api-ref.md file in doc folder as a text.

jacalata commented 2 years ago

merging into a staging branch to combine with the other changes I retrieved