search

tableau / document-api-python

Create and modify Tableau workbook and datasource files
https://tableau.github.io/document-api-python/
MIT License
333 stars 178 forks source link

Test get raw description #220

Closed jaybythebay closed 2 years ago

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Before we can merge this, we need @jaybythebay to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] commented 2 years ago

Thanks for the contribution! Unfortunately we can't verify the commit author(s): jaybythebay j***@h***.to. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

jacalata commented 2 years ago

Hi @jaybythebay, not quite sure what's up here - was this merge request accidental? It looks like it's just test code.

jaybythebay commented 2 years ago

Hey @jacalata This was definitely an accident and sorry about the false alarm. I thought I was comparing this to my fork and definitely clicked the wrong things here.

FYI, I am about to embark on some real code here. At my old company we had code in which we could do this:

  1. Edit SQL and a JSON Config with data definitions
  2. Airflow ran a job and downloaded Tableau Shared Data Sources. Refreshed the extracts, opened the files and edited the column comments with descriptions
  3. Airflow re-published the shared data sources

I'm planning on adding code to the document API that would help me re-create this without having written everything from scratch again. Do you see any problems with pursuing this approach? I know the document API doesn't currently supported editing the files but is there any reason that new code to do this wouldn't be allowed?

jacalata commented 2 years ago

I don't see any reason not to allow it - it sounds like some of that might be done using tsc/the REST API, such as the publishing step. Are you already familiar with that?

jaybythebay commented 2 years ago

We couldn't do this with the rest API 2 years ago but I'll check it out again before I code too much!

On Fri, Mar 11, 2022 at 1:12 PM Jac @.***> wrote:

I don't see any reason not to allow it - it sounds like some of that might be done using tsc/the REST API, such as the publishing step. Are you already familiar with that?

— Reply to this email directly, view it on GitHub https://github.com/tableau/document-api-python/pull/220#issuecomment-1065531301, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACKG6RDSTZZHAVCBG5OGTYDU7OZNJANCNFSM5PTND6XA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

--

Jay Rosenthal 510-725-2691