GET /favicon.ico gets a 404

tableau / extensions-api

Extensions API sample code and developer docs.

http://tableau.github.io/extensions-api

MIT License

268 stars 251 forks source link

GET /favicon.ico gets a 404 #211

Closed jstrauss18 closed 5 years ago

jstrauss18 commented 5 years ago

I have an extension published to our internal github bitbucket repository and am using the pages feature to serve up the html / js files. It can't find the favicon.ico because the GET is looking for it at root of github instead of in my app sub-directory (https://git.cnvrmedia.net/pages/BI/tableau-extensions). Can you offer any advice?

geordielad commented 5 years ago

Add a LINK element to your extention's html page(s): https://en.wikipedia.org/wiki/Favicon

jstrauss18 commented 5 years ago

thank you!!!! This did the trick, interestingly enough I had to modify the path dependent on whether it was the main page or config page.

Main page: link rel="icon" href="../favicon.ico" Config page: link rel="icon" href="../../favicon.ico"