tableau / extensions-api

Extensions API sample code and developer docs.
http://tableau.github.io/extensions-api
MIT License
268 stars 251 forks source link

falsy closeDialog payload causes internal error #99

Closed tjallingt closed 5 years ago

tjallingt commented 6 years ago

Even though payload is documented to be optional (https://tableau.github.io/extensions-api/docs/interfaces/ui.html#closedialog) if it is a falsy value (false, 0, ''or undefined) i get this error message: image

I'm aware that it is supposed to only take string arguments but even an empty string or undefined cause this error so it is definitely a bug somewhere.

Kovner commented 6 years ago

Ah good catch! I will log this internally. Thanks.